[clang-tools-extra] [clang] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 16 08:27:02 PST 2024


================
@@ -12,6 +12,7 @@
 #include "clang/AST/DeclCXX.h"
 #include "clang/AST/DeclTemplate.h"
 #include "clang/AST/DeclVisitor.h"
+#include "clang/AST/ODRHash.h"
----------------
erichkeane wrote:

We shouldn't be minimizing the #include set, but it is often a 'red flag' when someone adds one, so Corentin brought it up.  

IMO, I have no problem with adding the include here, and a IWYU RFC would be welcomed (and I am less concerned about the 'induce conflicts' as these are touched rarely).

https://github.com/llvm/llvm-project/pull/78041


More information about the cfe-commits mailing list