[clang] [Clang] Add a NULL check (PR #77131)

Joseph Huber via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 16 05:56:26 PST 2024


jhuber6 wrote:

Thanks for the patch, this one likely fell through the cracks because it has no assigned reviewers. We'll need a test based off of the original bug report. Put that in `clang/test/OpenMP/<your_test>.c` and then look at other tests for what it should look like. LLVM uses `lit` to test, you can run it yourself with `bin/llvm-lit -vv <path_to_your_test>.c` from the binary provided in the LLVM build.

If this function emits diagnostics and doesn't compile, then you should do a Sema check like the tests with "messages" in their name. If it's a codegen test, you can use the `update_cc_test_checks` script to autogenerate the LLVM-IR checks for the test and trim the ones you think are relevant. 

https://github.com/llvm/llvm-project/pull/77131


More information about the cfe-commits mailing list