[clang] 826fe84 - [clang][Interp][NFC] Remove outdated FIXME comment

Timm Bäder via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 15 03:04:15 PST 2024


Author: Timm Bäder
Date: 2024-01-15T12:03:59+01:00
New Revision: 826fe84a2cb7dd7e488bc6dc53ce6342f6e17e93

URL: https://github.com/llvm/llvm-project/commit/826fe84a2cb7dd7e488bc6dc53ce6342f6e17e93
DIFF: https://github.com/llvm/llvm-project/commit/826fe84a2cb7dd7e488bc6dc53ce6342f6e17e93.diff

LOG: [clang][Interp][NFC] Remove outdated FIXME comment

Virtual desturctors are already supported and tested in
AST/Interp/records.cpp.

Added: 
    

Modified: 
    clang/lib/AST/Interp/ByteCodeExprGen.cpp
    clang/test/AST/Interp/records.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/AST/Interp/ByteCodeExprGen.cpp b/clang/lib/AST/Interp/ByteCodeExprGen.cpp
index d6be9a306aeaf6..8863c5f89027e4 100644
--- a/clang/lib/AST/Interp/ByteCodeExprGen.cpp
+++ b/clang/lib/AST/Interp/ByteCodeExprGen.cpp
@@ -2951,7 +2951,6 @@ bool ByteCodeExprGen<Emitter>::emitPrimCast(PrimType FromT, PrimType ToT,
 /// When calling this, we have a pointer of the local-to-destroy
 /// on the stack.
 /// Emit destruction of record types (or arrays of record types).
-/// FIXME: Handle virtual destructors.
 template <class Emitter>
 bool ByteCodeExprGen<Emitter>::emitRecordDestruction(const Descriptor *Desc) {
   assert(Desc);

diff  --git a/clang/test/AST/Interp/records.cpp b/clang/test/AST/Interp/records.cpp
index 280eaf34898cec..a1ced049dcedb8 100644
--- a/clang/test/AST/Interp/records.cpp
+++ b/clang/test/AST/Interp/records.cpp
@@ -734,8 +734,6 @@ namespace VirtualDtors {
   }
 
   static_assert(foo());
-
-
 };
 
 namespace QualifiedCalls {


        


More information about the cfe-commits mailing list