[clang] [clang-format] Separate License text and include blocks (PR #77918)

Björn Schäpers via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 13 12:08:03 PST 2024


HazardyKnusperkeks wrote:

> > Maybe first only handle #42112 for what I will be really grateful.
> 
> #42112 requests separating both license text and include directives blocks.
> 

My bad, I only looked at the title, not the text.

> > And then the stuff with the _license_, because I see discussion there. As far as I can tell you just declare all comments on top of a file as license.
> 
> In my proposal, the license text is considered indeed to be a block of comments at the top of the source file, definitely up for discussion.
> 
> > I think you want too much in one change.
> 
> How do you suggest I should split the work?

You'd have to create multiple pull requests. And if they build on each other there is no nice way of doing this on github. You can of course use this one for a change.
You can also not split the work, but chances are it will take longer for the changes to land.

https://github.com/llvm/llvm-project/pull/77918


More information about the cfe-commits mailing list