[clang] [clang][Interp] Diagnose reads from non-const global variables (PR #71919)
Aaron Ballman via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 12 07:01:08 PST 2024
================
@@ -1005,12 +1008,23 @@ bool SetThisField(InterpState &S, CodePtr OpPC, uint32_t I) {
template <PrimType Name, class T = typename PrimConv<Name>::T>
bool GetGlobal(InterpState &S, CodePtr OpPC, uint32_t I) {
const Block *B = S.P.getGlobal(I);
+
+ if (!CheckConstant(S, OpPC, B->getDescriptor()))
+ return false;
if (B->isExtern())
return false;
S.Stk.push<T>(B->deref<T>());
return true;
}
+/// Same as GetGlobal, but without the checks.
+template <PrimType Name, class T = typename PrimConv<Name>::T>
+bool GetGlobalUnchecked(InterpState &S, CodePtr OpPC, uint32_t I) {
+ auto *B = S.P.getGlobal(I);
+ S.Stk.push<T>(B->deref<T>());
+ return true;
+}
+
----------------
AaronBallman wrote:
Eh probably not worth it then.
https://github.com/llvm/llvm-project/pull/71919
More information about the cfe-commits
mailing list