[clang] [clang][dataflow] Make cap on block visits configurable by caller. (PR #77481)

via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 12 00:17:18 PST 2024


================
@@ -138,13 +138,20 @@ struct TypeErasedDataflowAnalysisState {
 /// dataflow analysis cannot be performed successfully. Otherwise, calls
 /// `PostVisitCFG` on each CFG element with the final analysis results at that
 /// program point.
+///
+/// `MaxBlockVisits` caps the number of block visits during analysis. It doesn't
+/// distinguish between repeat visits to the same block and visits to distinct
+/// blocks. This parameter is a backstop to prevent infintite loops, in the case
+/// of bugs in the lattice and/or transfer functions that prevent the analysis
+/// from converging.
----------------
martinboehme wrote:

It looks as if `MaxBlockVisits` is further capped within the function, but the documentation doesn't talk about this.

Change either the implementation or the documentation to make them match?

https://github.com/llvm/llvm-project/pull/77481


More information about the cfe-commits mailing list