[clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

Piotr Zegar via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 11 11:06:44 PST 2024


================
@@ -0,0 +1,27 @@
+// RUN: %check_clang_tidy %s readability-ConditionalToStdMinMax %t
+
+void foo() {
+  int value1,value2;
+
+  // CHECK-MESSAGES: :[[@LINE+1]]:3: warning: use std::max instead of < [readability-ConditionalToStdMinMax]
+  if (value1 < value2)
+    value1 = value2; // CHECK-FIXES: value1 = std::max(value1, value2);
----------------
PiotrZSL wrote:

put those check fixes in new line, best after CHECK-MESSAGES, would be also nice to test that if gets removed

https://github.com/llvm/llvm-project/pull/77816


More information about the cfe-commits mailing list