[clang-tools-extra] [clangd] don't lower severity of clang-tidy modernize-* checks to remarks (PR #75706)

[Marzo Sette Torres Junior via cfe-commits]

marzojr wrote:

Coming from the issue I posted on `vscode-clangd`, I think it was a bad decision to make `modernize-*` checks basically disappear from the GUI. I feel less strongly with regards to `misc-unused-*` checks, but it is probably also true for those.

While trying to remove clutter is a good thing, I think this was done in the wrong way: there is no way to *opt into* the clutter if one wants to (which, one might argue, the user already *has* opted into when they enabled those checks in clang-tidy in the first place). As is, these warnings become nearly invisible, to the point of being useless -- if you *want* to address them, you either have to manually run clang-tidy from the command line, or go file by file scanning for strike-through text (which, in some cases, can be a single character wide), hovering over with the mouse to see if you want to fix it.

https://github.com/llvm/llvm-project/pull/75706