[clang] [libcxx] [llvm] [mlir] [mlir][sparse][CRunnerUtils] Add shuffle in CRunnerUtils (PR #77124)

Aart Bik via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 5 11:12:55 PST 2024


================
@@ -486,6 +486,10 @@ extern "C" MLIR_CRUNNERUTILS_EXPORT void *rtsrand(uint64_t s);
 extern "C" MLIR_CRUNNERUTILS_EXPORT uint64_t rtrand(void *, uint64_t m);
 // Deletes the random number generator.
 extern "C" MLIR_CRUNNERUTILS_EXPORT void rtdrand(void *);
+// Returns a pointer to an array of random numbers in the range of [0, s).
----------------
aartbik wrote:

Also, the in the range [0,s) is confusing. The numbers themselves are in the range [0,m) per the generator constructor. But this method simply returns an array of length s. Perhaps make that more clear too.

https://github.com/llvm/llvm-project/pull/77124


More information about the cfe-commits mailing list