[clang] [Clang] Correctly construct template arguments for template template parameters (PR #76811)

Younan Zhang via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 5 08:33:03 PST 2024


zyn0217 wrote:

Thank you for the feedback.

> I wouldn't be surprised if it is now being used in situations where the decl-context hasn't been appropriately updated

I think this is not the case where we’re dealing with ill-formed Decl-contexts; it is that the caller site doesn't respect the assumption that “the surrounding Decl for a TTPD shall be a file-scope decl”.

> I'd suggest looking to see if you can figure out where the correct arguments are.

I think I’ve already done that? (I have updated the patch to address it and that looks fine then), I’m just unsure if the removal for such assumption is appropriate. (or maybe i’m misreading your points? Should I change the call sites instead?) 




https://github.com/llvm/llvm-project/pull/76811


More information about the cfe-commits mailing list