[clang] [Serialization] Load Specializations Lazily (1/2) (PR #76774)

Chuanqi Xu via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 4 19:52:23 PST 2024


================
@@ -150,6 +150,11 @@ class ExternalASTSource : public RefCountedBase<ExternalASTSource> {
   virtual bool
   FindExternalVisibleDeclsByName(const DeclContext *DC, DeclarationName Name);
 
+  /// Load all the external specialzations for the Decl and the corresponding
+  /// template arguments.
+  virtual void LoadExternalSpecs(const Decl *D,
----------------
ChuanqiXu9 wrote:

I feel `Load` may be a better name. Since from the signature it doesn't find  anything. And if we want consistency, I suggest to rename `FindExternalVisibleDeclsByName ` to `LoadExternalVisibleDeclsByName`.

https://github.com/llvm/llvm-project/pull/76774


More information about the cfe-commits mailing list