[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 4 06:39:35 PST 2024


Pol Marcet =?utf-8?q?Sardà?= <polmarcetsarda at gmail.com>,
Pol Marcet =?utf-8?q?Sardà?= <polmarcetsarda at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/76615 at github.com>


================
@@ -10895,6 +10899,132 @@ bool VectorExprEvaluator::VisitUnaryOperator(const UnaryOperator *E) {
   return Success(APValue(ResultElements.data(), ResultElements.size()), E);
 }
 
+static bool EvaluateVectorOrLValue(APValue &Result, EvalInfo &Info,
----------------
erichkeane wrote:

This interface to this function seems really odd for the name?  Is the name inaccurate, or is this using 'false' to mean 'failure' AND 'not a vector'?  

It seems to me that this needs to be something like "EvaluateLValueVector" or something?

https://github.com/llvm/llvm-project/pull/76615


More information about the cfe-commits mailing list