[clang] 4de971c - [clang][ASTImporter] import InstantiatedFromMember of ClassTemplateSpecializationDecl (#76493)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 4 05:21:57 PST 2024
Author: Qizhi Hu
Date: 2024-01-04T21:21:53+08:00
New Revision: 4de971c230e8202cfd54d4d6c36719db628d35ce
URL: https://github.com/llvm/llvm-project/commit/4de971c230e8202cfd54d4d6c36719db628d35ce
DIFF: https://github.com/llvm/llvm-project/commit/4de971c230e8202cfd54d4d6c36719db628d35ce.diff
LOG: [clang][ASTImporter] import InstantiatedFromMember of ClassTemplateSpecializationDecl (#76493)
import of `ClassTemplateSpecializationDecl` didn't set
`InstantiatedFromMember` and this makes ast-dump crash. import and set
`InstantiatedFromMember`. fix
[issue](https://github.com/llvm/llvm-project/issues/76469)
Co-authored-by: huqizhi <836744285 at qq.com>
Added:
Modified:
clang/lib/AST/ASTImporter.cpp
clang/unittests/AST/ASTImporterTest.cpp
Removed:
################################################################################
diff --git a/clang/lib/AST/ASTImporter.cpp b/clang/lib/AST/ASTImporter.cpp
index b61180c4f3491d..9ffae72346f2af 100644
--- a/clang/lib/AST/ASTImporter.cpp
+++ b/clang/lib/AST/ASTImporter.cpp
@@ -6141,6 +6141,11 @@ ExpectedDecl ASTNodeImporter::VisitClassTemplateSpecializationDecl(
InsertPos))
// Add this partial specialization to the class template.
ClassTemplate->AddPartialSpecialization(PartSpec2, InsertPos);
+ if (Expected<ClassTemplatePartialSpecializationDecl *> ToInstOrErr =
+ import(PartialSpec->getInstantiatedFromMember()))
+ PartSpec2->setInstantiatedFromMember(*ToInstOrErr);
+ else
+ return ToInstOrErr.takeError();
updateLookupTableForTemplateParameters(*ToTPList);
} else { // Not a partial specialization.
diff --git a/clang/unittests/AST/ASTImporterTest.cpp b/clang/unittests/AST/ASTImporterTest.cpp
index ed8ecb080e268d..e4bd0d646cc9db 100644
--- a/clang/unittests/AST/ASTImporterTest.cpp
+++ b/clang/unittests/AST/ASTImporterTest.cpp
@@ -9342,6 +9342,39 @@ TEST_P(ASTImporterOptionSpecificTestBase, ImportConflictTypeAliasTemplate) {
EXPECT_FALSE(ImportedCallable);
}
+AST_MATCHER(ClassTemplateSpecializationDecl, hasInstantiatedFromMember) {
+ if (auto Instantiate = Node.getInstantiatedFrom()) {
+ if (auto *FromPartialSpecialization =
+ Instantiate.get<ClassTemplatePartialSpecializationDecl *>()) {
+ return nullptr != FromPartialSpecialization->getInstantiatedFromMember();
+ }
+ }
+ return false;
+}
+
+TEST_P(ASTImporterOptionSpecificTestBase, ImportInstantiatedFromMember) {
+ const char *Code =
+ R"(
+ template <typename> struct B {
+ template <typename, bool = false> union D;
+ template <typename T> union D<T> {};
+ D<int> d;
+ };
+ B<int> b;
+ )";
+ Decl *FromTU = getTuDecl(Code, Lang_CXX11);
+ auto *FromD = FirstDeclMatcher<ClassTemplateSpecializationDecl>().match(
+ FromTU, classTemplateSpecializationDecl(hasName("D"),
+ hasInstantiatedFromMember()));
+ auto *FromPartialSpecialization =
+ cast<ClassTemplatePartialSpecializationDecl *>(
+ FromD->getInstantiatedFrom());
+ ASSERT_TRUE(FromPartialSpecialization->getInstantiatedFromMember());
+ auto *ImportedPartialSpecialization =
+ Import(FromPartialSpecialization, Lang_CXX11);
+ EXPECT_TRUE(ImportedPartialSpecialization->getInstantiatedFromMember());
+}
+
INSTANTIATE_TEST_SUITE_P(ParameterizedTests, ASTImporterLookupTableTest,
DefaultTestValuesForRunOptions);
More information about the cfe-commits
mailing list