[llvm] [clang] [libcxx] "Reapply "[Sema] Fix crash on invalid code with parenthesized aggrega… (PR #76833)

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 4 02:48:58 PST 2024


ilya-biryukov wrote:

> @ilya-biryukov this is the new attempt to land this patch, the version you committed breaks the libc++ CI. I'll try to fix it this week.

Wow, I didn't expect that. Is libc++ ok with disabling this test until the nightly build catches up? (The PR is in the Draft state, so it's hard to tell if that's acceptable).

In the long-term, how should people land changes like this? Compiler diagnostics are expected to change sometimes, so we should figure out some way that allows landing these without reverts. Any thoughts?

https://github.com/llvm/llvm-project/pull/76833


More information about the cfe-commits mailing list