[libcxx] [lld] [llvm] [openmp] [libc] [lldb] [mlir] [compiler-rt] [flang] [clang] [clang-tools-extra] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

Mark de Wever via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 3 09:17:41 PST 2024


================
@@ -24,6 +24,10 @@
 
 #include "test_macros.h"
 
+#if _LIBCPP_STD_VER >= 26
----------------
mordante wrote:

This is the way to test for versions in the test suite.
```suggestion
#if TEST_STD_VER >= 26
```
The same for other places. Also since we can no longer use `native_handle_test_helpers` I prefer the use the C++ version guard in that header. (I know I asked for it's removal earlier, sorry).

https://github.com/llvm/llvm-project/pull/76632


More information about the cfe-commits mailing list