[clang] [Serialization] Load Specializations Lazily (1/2) (PR #76774)

Vassil Vassilev via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 3 00:05:29 PST 2024


================
@@ -1249,3 +1249,5 @@ void ODRHash::AddQualType(QualType T) {
 void ODRHash::AddBoolean(bool Value) {
   Bools.push_back(Value);
 }
+
+void ODRHash::AddInteger(unsigned Value) { ID.AddInteger(Value); }
----------------
vgvassilev wrote:

I remember @hahnjo and @zygoloid discussing that the odr-hasher is probably not the best way to has template arguments because the hasher would not take into account semantic aspects of template arguments. For example, a fully qualified template argument would not compare the same to a non-qualified one. We might need to implement our own folding set logic.

@hahnjo, could you help me out dig that discussion.

https://github.com/llvm/llvm-project/pull/76774


More information about the cfe-commits mailing list