[compiler-rt] [clang-tools-extra] [clang] [PGO] Exposing PGO's Counter Reset and File Dumping APIs (PR #76471)

Mingming Liu via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 2 15:10:53 PST 2024


minglotus-6 wrote:

> > thanks! Mostly lg with a pending discussion on whether we want to have test coverage for `clang_pgogen` in `compiler-rt/test/profile/instrprof-api.c`, and the open-ended discussion about the observed build failure in another compiler-rt test.
> 
> Thanks for the feedback! The latest commit aims at resolving all comments but the one related to the BE failure case. I will look into the BE related failure next.

Actually most compiler-rt test doesn't encounter the build failure as the specific test (`instrprof-thinlto-indirect-call-promotion.cpp`) does. I now begin to wonder if it has something to do with the fact that that affected test is C++ (intentionally not pure C to have mangled names)..

https://github.com/llvm/llvm-project/pull/76471


More information about the cfe-commits mailing list