[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

[Arthur Eubanks via cfe-commits]

aeubanks wrote:

same in our stage 2 build

```
 [4643/5157] Building CXX object tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o
 FAILED: tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o 
 /Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm-bootstrap-install/bin/clang++ -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/tools/dsymutil -I/Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm/llvm/tools/dsymutil -I/Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/include -I/Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm/llvm/include -isystem /Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm-build-tools/zstd-1.5.5/cmake_build/install/include -DSANITIZER_OVERRIDE_INTERCEPTORS -I/Volumes/Work/s/w/ir/cache/builder/src/tools/clang/scripts/sanitizers -DLIBXML_STATIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -fprofile-instr-use="/Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm-instrumented/profdata.prof" -O3 -DNDEBUG -std=c++17 -isysroot /Volumes/Work/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk -mmacosx-version-min=10.12  -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -MD -MT tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o -MF tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o.d -o tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o -c /Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm/llvm/tools/dsymutil/CFBundle.cpp
 /Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm/llvm/tools/dsymutil/CFBundle.cpp:15:10: fatal error: 'CoreFoundation/CoreFoundation.h' file not found
    15 | #include <CoreFoundation/CoreFoundation.h>
       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1 error generated.
```

if this is intended to be NFC but isn't, then we should probably revert

https://github.com/llvm/llvm-project/pull/75841