[clang-tools-extra] [clangd] don't lower severity of clang-tidy modernize-* checks to remarks (PR #75706)

[kadir çetinkaya via cfe-commits]

kadircet wrote:

hi @5chmidti and @HighCommander4!

it was deliberate to cover `modernize-` checks as they're pretty similar to `-wdeprecated` in nature, and they're both explicit, user needs to annotate code or opt-in for particular clang-tidy checks.

feedback we received in the past was, these kind of findings are hard to surface during builds, due to sheer amount of such findings in an existing code base. surfacing these findings on editing/review workflows OTOH is quite desirable to decrease the amount of new violations, but it can easily clutter any aggregate finding views (e.g. VSCode's problems panel).

Hence we went with emitting these as `Hints` with `Remarks` tags. So that editors have some signals to prevent such cluttering, while still displaying these findings, especially near the cursor where new code usually lives.

That being said, what exactly is the motivation for this patch? You mentioned `inconsistencies`, is it inside clangd or in other places that surface clang-tidy findings?

https://github.com/llvm/llvm-project/pull/75706