[llvm] [clang-tools-extra] [clang] [flang] [flang] Pass to add frame pointer attribute (PR #74598)

Andrzej WarzyƄski via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 22 09:17:56 PST 2023


================
@@ -0,0 +1,23 @@
+! Test that -mframe-pointer can accept only specific values.
----------------
banach-space wrote:

You seem to be testing a bit more in this file than this comment suggests (e.g. that `-mframe-pointer` will make the compiler insert the new attributes)

Please, could you:
* update the comment to capture what's actually being tested (the `-mframe-pointer` flag)
* rename the file - it's testing a particular flag rather than any "func"tion "attr"ibute

https://github.com/llvm/llvm-project/pull/74598


More information about the cfe-commits mailing list