[clang] [llvm] DiagnosticHandler: refactor error checking (PR #75889)
Teresa Johnson via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 19 09:25:18 PST 2023
================
@@ -256,10 +256,13 @@ void LLVMContext::diagnose(const DiagnosticInfo &DI) {
RS->emit(*OptDiagBase);
// If there is a report handler, use it.
- if (pImpl->DiagHandler &&
- (!pImpl->RespectDiagnosticFilters || isDiagnosticEnabled(DI)) &&
- pImpl->DiagHandler->handleDiagnostics(DI))
- return;
+ if (pImpl->DiagHandler) {
+ if (DI.getSeverity() == DS_Error)
+ pImpl->DiagHandler->HasErrors = true;
----------------
teresajohnson wrote:
Perhaps move the set of HasErrors into a new non-virtual method that we call below just before calling handleDiagnostics.
Also, should this be set when handleDiagnostics is not called?
https://github.com/llvm/llvm-project/pull/75889
More information about the cfe-commits
mailing list