[clang] [llvm] [HLSL][DirectX] Move handling of resource element types into the frontend (PR #75674)

Justin Bogner via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 18 09:35:40 PST 2023


================
@@ -253,35 +246,6 @@ void UAVResource::print(raw_ostream &OS) const {
   ResourceBase::print(OS, "U", "u");
 }
 
-// FIXME: Capture this in HLSL source. I would go do this right now, but I want
-// to get this in first so that I can make sure to capture all the extra
-// information we need to remove the source type string from here (See issue:
-// https://github.com/llvm/llvm-project/issues/57991).
----------------
bogner wrote:

This comment was kind of stale. That issue only mentioned capturing shape and ROV, which are both captured in the HLSL source before this change (and indeed the issue is closed). The issue this PR fixes is the obvious extension of that one, https://github.com/llvm/llvm-project/issues/70686

https://github.com/llvm/llvm-project/pull/75674


More information about the cfe-commits mailing list