[clang-tools-extra] [clangd] Add languages as server capabilities (PR #75633)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 15 09:48:44 PST 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clangd
Author: Chris B (llvm-beanz)
<details>
<summary>Changes</summary>
This change adds a list of supported langauges as part of the server capabilities. This is related to a PR to add HLSL support to the clangd VSCode plugin (https://github.com/clangd/vscode-clangd/pull/392).
The review there requested advertising HLSL support as a server capability. Adding a general "languages" capability seemed more appropriate.
---
Full diff: https://github.com/llvm/llvm-project/pull/75633.diff
2 Files Affected:
- (modified) clang-tools-extra/clangd/ClangdLSPServer.cpp (+2)
- (modified) clang-tools-extra/clangd/test/initialize-params.test (+8)
``````````diff
diff --git a/clang-tools-extra/clangd/ClangdLSPServer.cpp b/clang-tools-extra/clangd/ClangdLSPServer.cpp
index a87da252b7a7e9..4136155403fc1d 100644
--- a/clang-tools-extra/clangd/ClangdLSPServer.cpp
+++ b/clang-tools-extra/clangd/ClangdLSPServer.cpp
@@ -623,6 +623,8 @@ void ClangdLSPServer::onInitialize(const InitializeParams &Params,
{"clangdInlayHintsProvider", true},
{"inlayHintProvider", true},
{"foldingRangeProvider", true},
+ {"languages",
+ {"c", "cpp", "cuda-cpp", "objective-c", "objective-cpp", "hlsl"}},
};
{
diff --git a/clang-tools-extra/clangd/test/initialize-params.test b/clang-tools-extra/clangd/test/initialize-params.test
index a1fdae9870ab6e..81f00e0f469c52 100644
--- a/clang-tools-extra/clangd/test/initialize-params.test
+++ b/clang-tools-extra/clangd/test/initialize-params.test
@@ -48,6 +48,14 @@
# CHECK-NEXT: "implementationProvider": true,
# CHECK-NEXT: "inactiveRegionsProvider": true,
# CHECK-NEXT: "inlayHintProvider": true,
+# CHECK-NEXT: "languages": [
+# CHECK-NEXT: "c",
+# CHECK-NEXT: "cpp",
+# CHECK-NEXT: "cuda-cpp",
+# CHECK-NEXT: "objective-c",
+# CHECK-NEXT: "objective-cpp",
+# CHECK-NEXT: "hlsl"
+# CHECK-NEXT: ],
# CHECK-NEXT: "memoryUsageProvider": true,
# CHECK-NEXT: "referencesProvider": true,
# CHECK-NEXT: "renameProvider": true,
``````````
</details>
https://github.com/llvm/llvm-project/pull/75633
More information about the cfe-commits
mailing list