[clang] f32662a - [clang][Interp][NFC] Remove outdated FIXME comment

Timm Bäder via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 15 05:35:03 PST 2023


Author: Timm Bäder
Date: 2023-12-15T14:30:44+01:00
New Revision: f32662a40b0cc25f779ed10ea6515ba798922df8

URL: https://github.com/llvm/llvm-project/commit/f32662a40b0cc25f779ed10ea6515ba798922df8
DIFF: https://github.com/llvm/llvm-project/commit/f32662a40b0cc25f779ed10ea6515ba798922df8.diff

LOG: [clang][Interp][NFC] Remove outdated FIXME comment

This rework has already happened.

Added: 
    

Modified: 
    clang/lib/AST/Interp/ByteCodeExprGen.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/AST/Interp/ByteCodeExprGen.cpp b/clang/lib/AST/Interp/ByteCodeExprGen.cpp
index d0980882f402b9..e6b3097a80d8f7 100644
--- a/clang/lib/AST/Interp/ByteCodeExprGen.cpp
+++ b/clang/lib/AST/Interp/ByteCodeExprGen.cpp
@@ -563,8 +563,8 @@ bool ByteCodeExprGen<Emitter>::VisitLogicalBinOp(const BinaryOperator *E) {
 
 template <class Emitter>
 bool ByteCodeExprGen<Emitter>::VisitComplexBinOp(const BinaryOperator *E) {
-  // FIXME: We expect a pointer on the stack here.
-  //   we should not do that, but that's part of a bigger rework.
+  assert(Initializing);
+
   const Expr *LHS = E->getLHS();
   const Expr *RHS = E->getRHS();
   PrimType LHSElemT = *this->classifyComplexElementType(LHS->getType());


        


More information about the cfe-commits mailing list