[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 14 15:59:18 PST 2023


https://github.com/Yaraslaut created https://github.com/llvm/llvm-project/pull/75545

Closes https://github.com/llvm/llvm-project/issues/64144

Instead of checking for `nullptr`  we need to ensure that `JobList` is not empty to proceed

>From 052a12dfb78ddc7b1486ca5f8e06002bb55c1d2e Mon Sep 17 00:00:00 2001
From: Yaraslau Tamashevich <yaraslau.tamashevich at gmail.com>
Date: Fri, 15 Dec 2023 01:57:15 +0200
Subject: [PATCH] Fix check for empty Compilation

---
 clang/tools/clang-scan-deps/ClangScanDeps.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/tools/clang-scan-deps/ClangScanDeps.cpp b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
index 75aa4ae97c618c..7253856f1a07b4 100644
--- a/clang/tools/clang-scan-deps/ClangScanDeps.cpp
+++ b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
@@ -728,7 +728,7 @@ getCompilationDataBase(int argc, char **argv, std::string &ErrorMessage) {
                            *Diags);
   std::unique_ptr<driver::Compilation> C(
       TheDriver.BuildCompilation(CommandLine));
-  if (!C)
+  if (C->getJobs().empty())
     return nullptr;
 
   auto Cmd = C->getJobs().begin();



More information about the cfe-commits mailing list