[clang] [FPEnv] Add strictfp in some C++ constructors lacking a FunctionDecl. (PR #74883)

John McCall via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 14 12:25:22 PST 2023


================
@@ -5520,6 +5520,12 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo,
       CGM.AdjustMemoryAttribute(CalleePtr->getName(), Callee.getAbstractInfo(),
                                 Attrs);
   }
+  // We may not have a FunctionDecl*, but we still need to support strictfp.
----------------
rjmccall wrote:

This comment is explaining the patch, not explaining the code as it stands after the patch. I suggest removing this and just pulling the comment inside the `if` up here, since it explains why this block has to exist.

https://github.com/llvm/llvm-project/pull/74883


More information about the cfe-commits mailing list