[clang] [Clang][SVE2.1] Make a part of the name optional for `svwhileXX` builtins with predicate-as-counter (PR #75200)

Kerry McLaughlin via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 14 08:20:47 PST 2023


================
@@ -1,12 +1,20 @@
 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S -O1 -Werror -Wall -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefix=CPP-CHECK
+// RUN: %clang_cc1 -DSVE_OVERLOADED_FORMS -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -DSVE_OVERLOADED_FORMS -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S -O1 -Werror -Wall -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefix=CPP-CHECK
 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S -disable-O0-optnone -Werror -Wall -o /dev/null %s
----------------
kmclaughlin-arm wrote:

Thank you :)

I agree that having a single line to test both sve2p1 and sme2 would be preferable, however I'm not sure if this will be enough coverage when we add the streaming mode attribute to the builtins?

For SME2, we'll need to add `__arm_streaming` to the functions here as the tests should fail without it, but for SVE2p1 we do not need the attribute. @dtemirbulatov recently committed a patch for the pext & psel builtins which has both tests for SME2 & SVE2p1 and passes an extra option for the +sme2 lines to set the attribute: https://github.com/llvm/llvm-project/pull/72827.

https://github.com/llvm/llvm-project/pull/75200


More information about the cfe-commits mailing list