[clang] Add SPIRV support to HIPAMD toolchain (PR #75357)

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 14 07:14:25 PST 2023


yxsamliu wrote:

> > > > Is generic the best name here? I feel like that's going to be heavily overloaded. I'd much prefer a new architecture that just treats "SPIR-V" as a single architecture. E.g. `--offload-arch=spirv` or something.
> > 
> > 
> > For HIPAMD toolchain, `--offload-arch=generic` and `--offload-arch=spirv` does not make much difference. However, I understand for OpenMP toolchain `--offload-arch=generic` is probably too ambiguous and `--offload-arch=spirv` is better. I can change it to `spirv`.
> 
> Perhaps we should consider prefixing it in some way (e.g. `hip-spirv` or `amd-spirv`) that leaves the door open for some special handling (enable a particular set of extensions only for amdgpu targeting SPIRV, try to deal with missing builtins etc.) / flexibility?

I think amd-spirv may be a good choice since spirv itself is ambiguous about which HIP toolchain to choose since there are two HIP toolchains that support SPIRV: HIPAMD and HIPSPV.

https://github.com/llvm/llvm-project/pull/75357


More information about the cfe-commits mailing list