[clang] [clang] Report narrowing conversions with const references (PR #75332)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 14 06:11:48 PST 2023


================
@@ -10431,7 +10437,7 @@ static void DiagnoseNarrowingInInitList(Sema &S,
                                         : diag::warn_init_list_type_narrowing)
         << PostInit->getSourceRange()
         << PreNarrowingType.getLocalUnqualifiedType()
-        << EntityType.getLocalUnqualifiedType();
+        << EntityType.getLocalUnqualifiedType().getNonReferenceType();
----------------
erichkeane wrote:

I think we're talking past eachother then.  I was suggesting to remove the reference first, which would have us match GCC's behavior, right?  I think that is better than leaving it 'as is', but I was confused as to what is going on with the change on 10440 (removing the reference AFTER the qualifiers instead of before);

https://github.com/llvm/llvm-project/pull/75332


More information about the cfe-commits mailing list