[clang] [clang] Report narrowing conversions with const references (PR #75332)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 13 12:50:18 PST 2023


================
@@ -10431,7 +10437,7 @@ static void DiagnoseNarrowingInInitList(Sema &S,
                                         : diag::warn_init_list_type_narrowing)
         << PostInit->getSourceRange()
         << PreNarrowingType.getLocalUnqualifiedType()
-        << EntityType.getLocalUnqualifiedType();
+        << EntityType.getLocalUnqualifiedType().getNonReferenceType();
----------------
erichkeane wrote:

Since this is supposed to remove local qualifiers, should the reference be removed first?  What happens with a `const int &` as is?

ALSO, does the pre-narrowing-type also need to have references removed?

https://github.com/llvm/llvm-project/pull/75332


More information about the cfe-commits mailing list