[clang] [clang-tools-extra] [llvm] [compiler-rt] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

Fangrui Song via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 11 17:41:46 PST 2023


================
@@ -1,39 +0,0 @@
-; Do setup work for all below tests: generate bitcode and combined index
----------------
MaskRay wrote:

It looks like that we had 3 precanned profraw files and this patch is adding another one. Since the raw profile isn't stable, this is going to add some inconvenience whenever the version is bumped.
`thinlto_indirect_call_promotion.profraw` probably should be rewritten as `.proftext` and `llvm-profdata merge`
```
% fd -e profraw
Transforms/PGOProfile/Inputs/thinlto_indirect_call_promotion.profraw
tools/llvm-profdata/Inputs/basic.profraw
tools/llvm-profdata/Inputs/compressed.profraw
tools/llvm-profdata/Inputs/c-general.profraw
```

It seems that there is an earlier comment that proftext may not cover the use case well, so we also utilize a runtime test in `compiler-rt/test`.

https://github.com/llvm/llvm-project/pull/74008


More information about the cfe-commits mailing list