[clang] [compiler-rt] [clang-tools-extra] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

Fangrui Song via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 10 21:14:15 PST 2023


================
@@ -1,39 +0,0 @@
-; Do setup work for all below tests: generate bitcode and combined index
----------------
MaskRay wrote:

Hmm, I think it is still preferred to have a test here as runtime tests are more sensitive to the environment and may be skipped by some contributors.

It means we will have to duplicate some file between here and the runtime test. Perhaps adding a comment can help connect the two tests.

https://github.com/llvm/llvm-project/pull/74008


More information about the cfe-commits mailing list