[clang] [llvm] [NFC][InstrProf] Refactor InstrProfiling lowering pass (PR #74970)

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 10 01:01:58 PST 2023


================
@@ -31,31 +31,45 @@ using LoadStorePair = std::pair<Instruction *, Instruction *>;
 /// Instrumentation based profiling lowering pass. This pass lowers
 /// the profile instrumented code generated by FE or the IR based
 /// instrumentation pass.
-class InstrProfiling : public PassInfoMixin<InstrProfiling> {
+class InstrProfilingLoweringPass
+    : public PassInfoMixin<InstrProfilingLoweringPass> {
+  const InstrProfOptions Options;
+  // Is this lowering for the context-sensitive instrumentation.
+  const bool IsCS;
+
 public:
-  InstrProfiling() : IsCS(false) {}
-  InstrProfiling(const InstrProfOptions &Options, bool IsCS = false)
+  InstrProfilingLoweringPass() : IsCS(false) {}
----------------
kazutakahirata wrote:

We could "move" `false` to the declaration above:

`InstrProfilingLoweringPass() = default;`


https://github.com/llvm/llvm-project/pull/74970


More information about the cfe-commits mailing list