[llvm] [clang] [DirectX] Move ROV info into HLSL metadata. NFC (PR #74896)

David Peixotto via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 8 15:54:22 PST 2023


================
@@ -219,7 +221,7 @@ void CGHLSLRuntime::addBufferResourceAnnotation(llvm::GlobalVariable *GV,
          "ResourceMD must have been set by the switch above.");
 
   llvm::hlsl::FrontendResource Res(
-      GV, TyName, RK, Binding.Reg.value_or(UINT_MAX), Binding.Space);
+      GV, TyName, RK, IsROV, Binding.Reg.value_or(UINT_MAX), Binding.Space);
----------------
dmpots wrote:

Instead of a single `bool` here it might make sense to have some kind of `flags` field that we can extend as needed. I'm wondering what is special about ROV that we specifically need to flag them and if that is going to happen to other "weird" resource types (like Append/Consume buffers).

https://github.com/llvm/llvm-project/pull/74896


More information about the cfe-commits mailing list