[llvm] [compiler-rt] [clang-tools-extra] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

Mingming Liu via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 8 10:56:03 PST 2023


================
@@ -1,39 +1,45 @@
-; Do setup work for all below tests: generate bitcode and combined index
-; RUN: opt -module-summary %s -o %t.bc
-; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc
+; The raw profiles and reduced IR inputs are generated from Inputs/update_icall_promotion_inputs.sh
----------------
minglotus-6 wrote:

The script and c++ source is provided for on-demand update (e.g., version bump, etc). IIUC the goal of a `compiler-rt` test is to generate raw profiles from C++ source for each run of the IR test (`Transforms/PGOProfile/thinlto_indirect_call_promotion.ll`) (i.e.,the IR test would use the the output from the `compiler-rt` test). 

Practically, is there a way to run two tests one after the other so one could make use of the output of the other? Or shall the `compiler-rt` test verify the content of (raw or indexed) profile content?   (I'm assuming the IR test itself stays in `llvm/test/Transforms/PGOProfile` directory makes more sense here)



https://github.com/llvm/llvm-project/pull/74008


More information about the cfe-commits mailing list