[lldb] [clang] fixing issue #64441 (PR #74814)
Felipe de Azevedo Piovezan via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 8 06:21:47 PST 2023
https://github.com/felipepiovezan requested changes to this pull request.
Hi @jeevanghimire, thank you for the PR! I believe the original issue was not about changing LLVM test inputs, but rather about changing clang-tidy to warn about this kind of patterns.
Please see my rationale in a previous comment for why we should not be changing tests.
For future contributions, I'd also recommend using a more descriptive commit title and message. If you inspect the git log of the project, we generally follow the pattern:
[some topic] <imperative verb> <short title>
<commit description>
For example, this commit message could have been:
[clang-tidy] Implement "using namespace" check
https://github.com/llvm/llvm-project/pull/74814
More information about the cfe-commits
mailing list