[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 8 06:21:05 PST 2023


================
@@ -2884,6 +2884,12 @@ def warn_cxx11_compat_constexpr_body_multiple_return : Warning<
   InGroup<CXXPre14Compat>, DefaultIgnore;
 def note_constexpr_body_previous_return : Note<
   "previous return statement is here">;
+def err_ms_constexpr_not_distinct : Error<
+  "[[msvc::constexpr]] cannot be applied to a %select{constexpr|consteval}0 function %1">;
----------------
erichkeane wrote:

> After the latest changes, this is the only `msvc::constexpr` specific diagnostic left. What do you think if we use existing diagnostic messages with `constexpr` variant instead of introducing a new diagnostic message?

I believe that is a good idea

https://github.com/llvm/llvm-project/pull/71300


More information about the cfe-commits mailing list