[clang] [clang-tools-extra] [compiler-rt] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

Mingming Liu via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 7 23:52:00 PST 2023


================
@@ -1,39 +1,45 @@
-; Do setup work for all below tests: generate bitcode and combined index
-; RUN: opt -module-summary %s -o %t.bc
-; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc
+; The raw profiles and reduced IR inputs are generated from Inputs/update_icall_promotion_inputs.sh
----------------
minglotus-6 wrote:

Using a `.proftext` file (and convert it to indexed profiles in the test using `RUN` line) generally has better readability.

For better test coverage, I changed to store raw profile data in `Inputs/` directory and added some comments at the beginning of test case Transforms/PGOProfile/thinlto_indirect_call_promotion.ll

https://github.com/llvm/llvm-project/pull/74008


More information about the cfe-commits mailing list