[clang] a93cacf - [clang driver] Remove a bit of redundant flang specific code [nfc]

Philip Reames via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 6 14:21:36 PST 2023


Author: Philip Reames
Date: 2023-12-06T14:20:36-08:00
New Revision: a93cacf9b08f0780f2ae2832da10a9a841ae7d03

URL: https://github.com/llvm/llvm-project/commit/a93cacf9b08f0780f2ae2832da10a9a841ae7d03
DIFF: https://github.com/llvm/llvm-project/commit/a93cacf9b08f0780f2ae2832da10a9a841ae7d03.diff

LOG: [clang driver] Remove a bit of redundant flang specific code [nfc]

getOptionVisibilityMask already returns options::FlangOption in FlangMode,
so this assignment is entirely pointless.

Added: 
    

Modified: 
    clang/lib/Driver/Driver.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp
index 6f5ff81410326..e241706b9082e 100644
--- a/clang/lib/Driver/Driver.cpp
+++ b/clang/lib/Driver/Driver.cpp
@@ -1940,12 +1940,6 @@ int Driver::ExecuteCompilation(
 void Driver::PrintHelp(bool ShowHidden) const {
   llvm::opt::Visibility VisibilityMask = getOptionVisibilityMask();
 
-  // TODO: We're overriding the mask for flang here to keep this NFC for the
-  // option refactoring, but what we really need to do is annotate the flags
-  // that Flang uses.
-  if (IsFlangMode())
-    VisibilityMask = llvm::opt::Visibility(options::FlangOption);
-
   std::string Usage = llvm::formatv("{0} [options] file...", Name).str();
   getOpts().printHelp(llvm::outs(), Usage.c_str(), DriverTitle.c_str(),
                       ShowHidden, /*ShowAllAliases=*/false,


        


More information about the cfe-commits mailing list