[clang-tools-extra] [clang] [compiler-rt] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

Mingming Liu via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 6 14:03:48 PST 2023


minglotus-6 wrote:

> > > David says the itanium remapper file was only used once during gcc to llvm transition, so not relevant here.
> > 
> > 
> > I believe it was actually for the libstdc++ to libc++ transition (see https://reviews.llvm.org/D51247 and https://reviews.llvm.org/D51240).
> > If it is broken we'll at least want to add a FIXME there.
> 
> Yes, I meant libstdc++ to libc++ transition. Why source line is this comment addressing? I take take a look the changes/comments there.

Sorry for the misinformation. I think the itanium remapper needs a `:` -> `;` update (going to update this PR and tests to do it), since (for local-linkage functions) the function name used to look up profiles should use `;` delimiter. 

https://github.com/llvm/llvm-project/pull/74008


More information about the cfe-commits mailing list