[clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

[Bill Wendling via cfe-commits]

bwendling wrote:

> I actually think bdos is more complicated: array bounds checking can handle arbitrary base expressions, so it doesn't need to examine the base expression at all. bdos can't do that, so more work is required to handle precisely the cases you want to handle.

Yup! The code I wrote handles as many cases as we're able to, i.e. all where we don't have to emit an expression with side-effects.

https://github.com/llvm/llvm-project/pull/73730