[clang] [llvm] [LLVM][IR] Add native vector support to ConstantInt & ConstantFP. (PR #74502)

[Nikita Popov via cfe-commits]

================
@@ -343,7 +343,7 @@ static bool verifyTripCount(Value *RHS, Loop *L,
     // If the RHS of the compare is equal to the backedge taken count we need
     // to add one to get the trip count.
     if (SCEVRHS == BackedgeTCExt || SCEVRHS == BackedgeTakenCount) {
-      ConstantInt *One = ConstantInt::get(ConstantRHS->getType(), 1);
+      ConstantInt *One = ConstantInt::get(ConstantRHS->getIntegerType(), 1);
----------------
nikic wrote:

I don't really follow here. Even if you rename the overload on ConstantInt, there will still be the method inherited from `Value::getType()`, and using that method here should work (and be forward-compatible with vector ConstantInt), because `ConstantInt::get` doesn't actually require that the argument is an IntegerType.

https://github.com/llvm/llvm-project/pull/74502