[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

kadir çetinkaya via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 4 07:28:42 PST 2023


================
@@ -189,6 +189,10 @@ llvm::Expected<clangd::Ref> Marshaller::fromProtobuf(const Ref &Message) {
     return Location.takeError();
   Result.Location = *Location;
   Result.Kind = static_cast<RefKind>(Message.kind());
+  auto ContainerID = SymbolID::fromStr(Message.container());
+  if (!ContainerID)
+    return ContainerID.takeError();
----------------
kadircet wrote:

this shouldn't be a failure, as an old server might provide a ref response without a container, but the clients should still keep working.

https://github.com/llvm/llvm-project/pull/71605


More information about the cfe-commits mailing list