[clang] Fix dr2xx clang test (PR #74223)

via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 2 20:05:06 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Sizov Nikita (snikitav)

<details>
<summary>Changes</summary>

Currently windows build fails with:

```
# | error: 'cxx98-14-error' diagnostics expected but not seen: 
# |   File C:\ws\src\clang\test\CXX\drs\dr2xx.cpp Line 1297 (directive at C:\ws\src\clang\test\CXX\drs\dr2xx.cpp:1301): {{conversion from 'T' to 'unsigned (long|int)' is ambiguous}}
```

Obviously, there is an excessive pair of brackets

---
Full diff: https://github.com/llvm/llvm-project/pull/74223.diff


1 Files Affected:

- (modified) clang/test/CXX/drs/dr2xx.cpp (+1-1) 


``````````diff
diff --git a/clang/test/CXX/drs/dr2xx.cpp b/clang/test/CXX/drs/dr2xx.cpp
index 4dd6d7599f2a0..170753e5efce4 100644
--- a/clang/test/CXX/drs/dr2xx.cpp
+++ b/clang/test/CXX/drs/dr2xx.cpp
@@ -1298,7 +1298,7 @@ namespace dr299 { // dr299: 2.8 c++11
   // cxx98-11-error@#dr299-q {{ambiguous conversion of array size expression of type 'T' to an integral or enumeration type}}
   //  cxx98-11-note@#dr299-int {{conversion to integral type 'int' declared here}}
   //  cxx98-11-note@#dr299-ushort {{conversion to integral type 'unsigned short' declared here}}
-  // since-cxx14-error-re@#dr299-q {{{{conversion from 'T' to 'unsigned (long|int)' is ambiguous}}}}
+  // since-cxx14-error-re@#dr299-q {{conversion from 'T' to 'unsigned (long|int)' is ambiguous}}
   //  since-cxx14-note@#dr299-int {{candidate function}}
   //  since-cxx14-note@#dr299-ushort {{candidate function}}
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/74223


More information about the cfe-commits mailing list