[llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

[Ellis Hoag via cfe-commits]

================
@@ -300,12 +316,8 @@ getIRPGONameForGlobalObject(const GlobalObject &GO,
                             GlobalValue::LinkageTypes Linkage,
                             StringRef FileName) {
   SmallString<64> Name;
-  if (llvm::GlobalValue::isLocalLinkage(Linkage)) {
-    Name.append(FileName.empty() ? "<unknown>" : FileName);
-    Name.append(";");
-  }
   Mangler().getNameWithPrefix(Name, &GO, /*CannotUsePrivateLabel=*/true);
----------------
ellishg wrote:

Here is the unittest for these functions which shows some examples. Even for c++ names there are differences

https://github.com/llvm/llvm-project/blob/70187ebadf20f014a7821cf322eae60192dbe4cc/llvm/unittests/ProfileData/InstrProfTest.cpp#L542-L609

https://github.com/llvm/llvm-project/pull/74008