[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-init: Add a hook... (PR #73921)

[Clement Courbet via cfe-commits]

================
@@ -302,6 +303,20 @@ void UnnecessaryCopyInitialization::check(
   }
 }
 
+void UnnecessaryCopyInitialization::makeDiagnostic(
+    DiagnosticBuilder Diagnostic, const VarDecl &Var, const Stmt &BlockStmt,
----------------
legrosbuffle wrote:

Done. I've kept the code common to these two functions factored out into `maybeIssueFixes`, and I've created a helper struct for the 5 common parameters to these two functions (and the additional 2 boolean variables that these two have in common).

https://github.com/llvm/llvm-project/pull/73921