[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-init: Add a hook... (PR #73921)

Piotr Zegar via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 30 02:57:48 PST 2023


PiotrZSL wrote:

First what's a purpose of this change. Is there any other check that will need it or not ?
Second is that actually onWarningEmitted should be more a emitWarning, and those diag should be inside it, so that they could be changed if needed. Or condition required to emit a warning should be in separate methods.
With current implementation I don't see any "custom behaviour" that could be implemented, as this act more like observer.

https://github.com/llvm/llvm-project/pull/73921


More information about the cfe-commits mailing list