[clang] [llvm] [MemProf] Expand optimization scope to internal linakge function (PR #73236)
Teresa Johnson via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 29 08:56:31 PST 2023
teresajohnson wrote:
> > Yes, you're right. As an alternative can we use the symbol table and find Bind = LOCAL to add the prefix before hashing?
>
> If we choose this method. I think we can't deal with the situation which one symbol is not local linkage type in thin compile, but will be converted to local linkage after thin backend by thinlto's internalization. In this situation function name in llvm-profdata will have prefix with file name. But when llvm consumes memory profile, PGOFuncName won't return function name with prefix.
If I understand the issue you are describing, that would only occur if the instrumentation build also used ThinLTO. Is that a typical use case for you?
https://github.com/llvm/llvm-project/pull/73236
More information about the cfe-commits
mailing list