[clang-tools-extra] [clangd] Improve BlockEnd inlay hints presentation (PR #72345)

Nathan Ridge via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 26 17:35:20 PST 2023


HighCommander4 wrote:

Thanks, the behaviour changes look reasonable to me.

> I haven't update the test because the hard-coded limit 10 makes it hard to write the tests. Any opinion of how to structure this?

I would suggest running most tests with `HintMinLineLimit = 2` (and then have one test for the behaviour with `HintMinLineLimit = 10`).

To allow the tests to change `HintMinLineLimit`, we could give the `inlayHints()` function an optional parameter to specify it (could wrap it in an `InlayHintOptions` class for adding other options in the future).

https://github.com/llvm/llvm-project/pull/72345


More information about the cfe-commits mailing list