[clang] [clang] Fix sorting module headers (PR #73146)

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 22 14:50:18 PST 2023


dwblaikie wrote:

> This commit also fixes commit https://github.com/llvm/llvm-project/commit/d3676d4b666ead794fc58bbc7e07aa406dcf487a that caused all headers to have NameAsWritten set to a 0-length string without adapting compareModuleHeaders() to the new field.

Sorry, I don't quite understand tnhis - but I guess the second field ( PathRelativeToRootModuleDirectory ) comparison was to address this bug? It'd probably be good to fix that separately, so it can be discussed in more detail, etc.

https://github.com/llvm/llvm-project/pull/73146


More information about the cfe-commits mailing list